Timimi icon indicating copy to clipboard operation
Timimi copied to clipboard

Change in settings doesn't take effect unless restarted

Open PengjuYan opened this issue 5 years ago • 4 comments

Reproduce (macOS, TWC, FireFox) (I guess this issue does not apply only to TWC files):

  1. Suppose there are two folders "backup1" and "backup2" relative to your TWC file.

  2. Suppose you have originally set the "Backup location" to be "backup1".

  3. Open a TWC file in FireFox.

  4. You now change the "Backup location" to be "backup2" and then click "Save" to store the settings of Timimi.

  5. You save your TWC file.

  6. You can see the latest backup appear in "backup1" in stead of "backup2".

PengjuYan avatar Jul 22 '19 06:07 PengjuYan

I have to note that Timimi backuping was not implemented for TWC yet (the message should also get data-tiddlyfox-backup-path attribute for supporting backuping), so I'm not sure what's the status of this issue. To implement the support of backuping, I need to understand the expected format of the backup path (help of @ibnishak would be nice here).

YakovL avatar Jul 22 '19 07:07 YakovL

I think the backing-up is automatically there and I'm enjoying it right now. :-) Although Timimi doesn't handle the backing-up message (which I suspect, because I can see "TWC backup" files saved there in fact), it will back up anything that indicated by a tiddlyfox-save-file message.

Please refer to my last post at New saver! Adapting Timimi for TWC.

Both TWC's "SaveBackups" and Timimi's "Create backup" take effect if you enable them.

PengjuYan avatar Jul 22 '19 07:07 PengjuYan

Although Timimi doesn't handle the backing-up message (which I suspect, because I can see "TWC backup" files saved there in fact), it will back up anything that indicated by a tiddlyfox-save-file message.

Hm.. this is unexpected; if so, this should be documented (or fixed? may be after implementing backups support for TWC). I'll probably take a look at source code, although I'm not that familiar with GoLang

YakovL avatar Jul 23 '19 07:07 YakovL

@ibnishak I'm not sure it's good idea to assign this one to me: I can retest this on Win and then with TW5, but if that's macOS-specific issue, it would be hard to solve (I don't have a mac device). What should be assigned to me is yet non-existing issue about consistent support of backuping of TWC. Well, I'll take a look though.

YakovL avatar Jul 26 '19 06:07 YakovL