tjbot icon indicating copy to clipboard operation
tjbot copied to clipboard

Upgrade node.js version on bootstrap script

Open robertoetcheverryr opened this issue 3 years ago • 1 comments

Hello, I just ran the tjbot bootstrap on my tjbot (I inherited from a coworker, so now I'm fully updating it) And noticed that it installs node.js v15 which is not supported. I am not a node.js dev so I do not know how difficult it would be to test the code against v16 and change the installation script, so I open this issue to see how feasible it is.

robertoetcheverryr avatar Oct 10 '21 02:10 robertoetcheverryr

@robertoetcheverryr I'm not sure what you mean by "which is not supported"?

It's likely safe to use whatever the latest Node.js version is with TJBot. The bootstrap script installs v15 because that was the latest major version the last time I updated the script, and I can at least assert that TJBot was tested against Node v15.

I suppose we could have the bootstrap script install the latest version of Node.js and just cross our fingers that future releases of Node.js won't cause TJBot to break.

jweisz avatar Oct 21 '21 14:10 jweisz

Update needs to happen in bootstrap.sh lines 138-168

https://github.com/ibmtjbot/tjbot/blob/master/bootstrap/bootstrap.sh

jweisz avatar Jan 27 '23 15:01 jweisz

We accepted this PR: https://github.com/ibmtjbot/tjbot/pull/225

jweisz avatar Mar 24 '23 14:03 jweisz