faulty logic in suite_manage_attachments / custfiles ?

[faangbait]

Collection version

29.1.1

Environment information

n/a

What happened?

I want to highlight some logical inconsistencies between the suite_manage_attachments_config and suite_manage_customer_files_config.

I'm not sure if these are bugs, or if this is the intended behavior. Looking for feedback. There might be a couple more; but these are the ones I saw when I sat down to write this ticket.

Access Points

Attachment config sets up access points for the bucket; Customer Files doesn't.

• https://github.com/ibm-mas/ansible-devops/blob/15ca45baaac340922aabcb10007812f07958a47f/ibm/mas_devops/roles/suite_manage_attachments_config/tasks/common/aws-setup-bucket-permissions.yml#L82
• https://github.com/ibm-mas/ansible-devops/blob/15ca45baaac340922aabcb10007812f07958a47f/ibm/mas_devops/roles/suite_manage_customer_files_config/tasks/providers/aws/setup_bucket_permissions.yml

Theory: Attachment should configure access points, as the comment here suggests that it will. https://github.com/ibm-mas/ansible-devops/blob/15ca45baaac340922aabcb10007812f07958a47f/ibm/mas_devops/roles/suite_manage_attachments_config/tasks/common/configure-bucket.yml#L10

Permissions, etc

Custfiles config only sets permissions on the main custfiles bucket, not on custfiles-recovery or custfiles-backup

• https://github.com/ibm-mas/ansible-devops/blob/15ca45baaac340922aabcb10007812f07958a47f/ibm/mas_devops/roles/suite_manage_customer_files_config/tasks/setup-manage-custfiles.yml

Theory: Probably want to set the same permissions/access points on all three.

Configure Bundles

Attachments has a configure-bundles.yml / configure-database.yml script that calls wait-bundle-pods.yml, which restarts the pods. Customer Files has a wait-bundle-pods.yml, but it is never called

• https://github.com/ibm-mas/ansible-devops/blob/15ca45baaac340922aabcb10007812f07958a47f/ibm/mas_devops/roles/suite_manage_customer_files_config/tasks/wait_bundle_pods.yml
• https://github.com/ibm-mas/ansible-devops/blob/15ca45baaac340922aabcb10007812f07958a47f/ibm/mas_devops/roles/suite_manage_attachments_config/tasks/common/wait-bundle-pods.yml

Theory: Somebody deleted the configure-bundles/configure-database from Customer Files because the idea of properties being db/cr-based is not applicable to Customer Files. However, I suspect the bundle pods still need to be restarted to pick up the new mountpoints, no? If that's why wait-bundle-pods wasn't removed from customer files config, then it should be called by something. Either way, it's an orphan.

Relevant log output

n/a