shell icon indicating copy to clipboard operation
shell copied to clipboard

"clickable" text but not actually clickable in about page

Open rabbah opened this issue 7 years ago • 2 comments

notice hovering on the text under the icon it turns blue, suggesting it's clickable (css style says so too) but there's no link defined... Should perhaps do the same as the icon?

may-18-2018 10-18-21

note: i noticed the mouse cursor wasn't captured in the gif but i think enough to make the point.

rabbah avatar May 18 '18 14:05 rabbah

thanks for the bug report. yup, i think this is a bug in the about npm that we're using. it's supposed to be a link to the project page.

starpit avatar May 18 '18 14:05 starpit

weird, i just looked, and for some reason the onclick handler that the about-window npm installs just doesn't fire. is this a chrome bug? an electron bug? dunno. if i elt.setAttribute('onclick', ...) then i get an event to fire. but neither elt.onclick nor elt.addEventListener('click') do anything.

oddly, the code registers the onclick handler for the icon using the same structure, and it fires just fine.

starpit avatar May 21 '18 14:05 starpit