shell icon indicating copy to clipboard operation
shell copied to clipboard

--log-all/input/inline fail

Open kerryspchang opened this issue 7 years ago • 3 comments

--log-all/input/inline options for app create/update stop working after changing to composer v2.

kerryspchang avatar Mar 08 '18 05:03 kerryspchang

before fixing this, i'd like to take a step back and consider how we will more generally address graph rewriting.

starpit avatar Mar 10 '18 15:03 starpit

we also have no test coverage for this feature

starpit avatar Mar 13 '18 01:03 starpit

The previous way to implement this is to insert a new state as the first state and after each inline function state to log the data. The new state could be an inline function that is p => {console.log("data: "+JSON.stringify(p)); return p;} to log the data in the conductor activation logs, or an action that calls whisk.system/utils/echo to log the data in a separate activation.

@starpit when you mention "how we will more generally address graph rewriting" are you thinking to implement some more general purpose utility functions to modify the graph? I can implement something like a graph.insertAfter(targetStates, insertStates) to reuse the behavior.

kerryspchang avatar Mar 20 '18 22:03 kerryspchang