ibis icon indicating copy to clipboard operation
ibis copied to clipboard

feat(types): isoyear method

Open kaijennissen opened this issue 10 months ago • 3 comments

  • first steps for implementing iso_year method
  • added isoyear method for duckdb

Description of changes

Added a new isoyear method for timestamps.

Issues closed

Resolved #8989

kaijennissen avatar Apr 21 '24 12:04 kaijennissen

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

github-actions[bot] avatar Apr 21 '24 12:04 github-actions[bot]

@cpcloud I'm not sure where the corresponding tests should be placed?

  • Inside ibis/tests/expr/test_timestampy.py
    • as new parametrization of test_extract_fields
    • as a new test function, f.e. test_iso_year
  • Inside ibis/backends/tests/test_temportal.py

kaijennissen avatar Apr 21 '24 12:04 kaijennissen

Hey @kaijennissen!

For tests of ibis internals, like does the extract operation return the Ibis type we expect for a given input, those go in ibis/tests/expr.

For testing execution against backends (does the operation do what we want, which backends are implemented, etc), those go in ibis/backends/tests

gforsyth avatar Apr 22 '24 15:04 gforsyth