ibis icon indicating copy to clipboard operation
ibis copied to clipboard

test(duckdb): get things passing with duckdb 0.10.0

Open cpcloud opened this issue 1 year ago • 2 comments
trafficstars

Get tests passing with duckdb 0.10.0

cpcloud avatar Feb 16 '24 00:02 cpcloud

I'm going to unwind these cotangent changes and address the inconsistency in a follow-up PR.

cpcloud avatar Feb 16 '24 13:02 cpcloud

Well, not a huge fan of merging a dependency that results in a segfault.

I don't have a windows machine lying around to test this either.

cpcloud avatar Feb 16 '24 17:02 cpcloud

Reported the failure here: https://github.com/duckdb/duckdb/issues/10787

cpcloud avatar Feb 21 '24 13:02 cpcloud

I'm going to rehash and force push a couple of times to see if the problem can be reproduced when running tests serially.

cpcloud avatar Feb 21 '24 13:02 cpcloud

Looks like something is causing a core dump on Linux now: https://github.com/ibis-project/ibis/actions/runs/7994707013/job/21833372662?pr=8373

😞

cpcloud avatar Feb 22 '24 12:02 cpcloud

Looks like something is causing a core dump on Linux now: https://github.com/ibis-project/ibis/actions/runs/7994707013/job/21833372662?pr=8373

Given that this stopped in geospatial, my guess is that this is the same than https://github.com/duckdb/duckdb_spatial/issues/236

If so, good news is Max and Tishj identified the problem comes from the spatial extension, and they can reproduce it. Bad news is this might not be fixed until the next release of the spatial extension (idk when would that be).

ncclementi avatar Feb 22 '24 14:02 ncclementi

I guess we can't really test 0.10 in CI until some of these issues are straightened out. I don't really want to be chasing aborts and segfaults.

cpcloud avatar Feb 22 '24 14:02 cpcloud

So this is fixed https://github.com/duckdb/duckdb_spatial/issues/236 for v0.10.0 and the current nightly version of the spatial extension. Once that spatial extension gets released, we can recap here.

ncclementi avatar Mar 01 '24 17:03 ncclementi

Running tests serially seems to sidestep the windows segfault for now, and the geospatial issue doesn't seem to reproduce anymore.

I'll trigger a few more CI runs to see if they're still an issue and then we can merge if those don't yield anything useful.

cpcloud avatar Mar 04 '24 13:03 cpcloud

@ncclementi @gforsyth @jcrist Anyone opposed to merging this?

The windows segfaults don't seem to reproduce under serial testing (not great, but reported upstream) and the linux crashes also do not reproduce. I don't see a release of the geospatial extension, but I also have no idea whether we're picking up a fix or not in CI when we run install geospatial;

cpcloud avatar Mar 06 '24 17:03 cpcloud