ibis icon indicating copy to clipboard operation
ibis copied to clipboard

fix: fix comparisons for nested types

Open cpcloud opened this issue 3 years ago • 2 comments

Fixes a bug where substitution occurs and triggers a correct TypeError but the TypeError is not specific enough.

cpcloud avatar Sep 22 '22 00:09 cpcloud

Test Results

       35 files         35 suites   1h 14m 48s :stopwatch:   9 861 tests   7 775 :heavy_check_mark: 2 086 :zzz: 0 :x: 36 021 runs  27 978 :heavy_check_mark: 8 043 :zzz: 0 :x:

Results for commit c31f8d1c.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 22 '22 01:09 github-actions[bot]

Codecov Report

Merging #4559 (c31f8d1) into master (ae07438) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4559   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files         183      183           
  Lines       20007    20007           
  Branches     2961     2961           
=======================================
  Hits        18516    18516           
  Misses       1114     1114           
  Partials      377      377           
Impacted Files Coverage Δ
ibis/expr/analysis.py 95.54% <100.00%> (ø)

codecov[bot] avatar Sep 22 '22 01:09 codecov[bot]