ibis icon indicating copy to clipboard operation
ibis copied to clipboard

feat(ir): experimental egraph integration

Open kszucs opened this issue 3 years ago • 2 comments

egraph/egg is an alternative term rewriting system to matchpy thus this integration provides an alternative to #4437

It uses a refactored version of snake-egg python bindings from my fork

kszucs avatar Sep 09 '22 11:09 kszucs

Codecov Report

Merging #4478 (47b651a) into 4.x.x (119a983) will decrease coverage by 2.80%. The diff coverage is 94.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.x.x    #4478      +/-   ##
==========================================
- Coverage   92.79%   89.99%   -2.81%     
==========================================
  Files         180      180              
  Lines       20088    19743     -345     
  Branches     2853     2907      +54     
==========================================
- Hits        18640    17767     -873     
- Misses       1090     1540     +450     
- Partials      358      436      +78     
Impacted Files Coverage Δ
ibis/backends/impala/__init__.py 86.14% <ø> (+0.21%) :arrow_up:
ibis/backends/impala/udf.py 82.75% <ø> (ø)
ibis/backends/postgres/__init__.py 100.00% <ø> (ø)
ibis/backends/pyarrow/operations.py 0.00% <0.00%> (ø)
ibis/common/dispatch.py 96.66% <ø> (+0.37%) :arrow_up:
ibis/common/geospatial.py 74.35% <ø> (-0.33%) :arrow_down:
ibis/common/grounds.py 92.20% <ø> (-4.49%) :arrow_down:
ibis/common/validators.py 92.23% <ø> (-6.47%) :arrow_down:
ibis/config.py 86.15% <ø> (ø)
ibis/expr/analysis.py 87.72% <ø> (-10.07%) :arrow_down:
... and 197 more

codecov[bot] avatar Sep 09 '22 12:09 codecov[bot]

Test Results

       35 files         35 suites   1h 16m 14s :stopwatch:   9 555 tests   7 628 :heavy_check_mark: 1 927 :zzz: 0 :x: 34 937 runs  27 403 :heavy_check_mark: 7 534 :zzz: 0 :x:

Results for commit 47b651a7.

github-actions[bot] avatar Sep 09 '22 14:09 github-actions[bot]

@kszucs Should we close the matchpy PR in favor of this one?

cpcloud avatar Oct 06 '22 20:10 cpcloud

Well, I'm not sure which one should be the preferred one. Going to rebase them for now.

kszucs avatar Oct 06 '22 21:10 kszucs

Closing this in favor of https://github.com/ibis-project/ibis/pull/5781

kszucs avatar Mar 28 '23 10:03 kszucs