ibis
ibis copied to clipboard
ibis-project
Ibis design draft: Tabular user-defined tables (UDTs)
This is a design draft not intended to be committed. The code is part of an Ibis/Substrait/PyArrow prototype.
Hello @rtpsw! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
ibis/expr/operations/relations.py:
Line 127:16: E124 closing bracket does not match visual indentation Line 133:16: E124 closing bracket does not match visual indentation Line 139:16: E124 closing bracket does not match visual indentation
- In the file
ibis/expr/schema.py:
Line 152:38: F502 '...' % ... expected mapping but got sequence Line 152:80: E501 line too long (111 > 79 characters)
- In the file
ibis/expr/types/numeric.py:
Line 142:14: F821 undefined name 'ops' Line 142:28: F821 undefined name 'self' Line 164:14: F821 undefined name 'ops' Line 164:28: F821 undefined name 'self'
- In the file
ibis/expr/types/relations.py:
Line 669:80: E501 line too long (82 > 79 characters) Line 684:16: F821 undefined name 'ops' Line 689:22: F821 undefined name 'List' Line 723:27: E126 continuation line over-indented for hanging indent Line 726:26: E126 continuation line over-indented for hanging indent
For the UDT design, please see the following:
TabularUserDefinedFunctionin ibis/expr/operations/tabular.py- ibis/udf/table.py
- ibis/expr/operations/udf.py
VectorizedUDFin ibis/expr/operations/vectorized.py
Please show an example of usage, in a test preferably.
There is a simple UDT tester available in the Ibis-Substrait draft.
@rtpsw Is this PR still viable? Happy to review it more, but it looks like maybe it's a bit stale now.
@rtpsw Is this PR still viable? Happy to review it more, but it looks like maybe it's a bit stale now.
@icexelloss, given current priorities, do we want to push this in the near future?