ibis icon indicating copy to clipboard operation
ibis copied to clipboard

refactor(ir): remove intermediate expressions [WIP]

Open kszucs opened this issue 3 years ago • 2 comments

Rolled up version of https://github.com/ibis-project/ibis/pull/4135 rebased on top of:

  • 4.x.x branch
  • https://github.com/ibis-project/ibis/pull/4215
  • https://github.com/ibis-project/ibis/pull/4216
  • https://github.com/ibis-project/ibis/pull/4063
  • https://github.com/ibis-project/ibis/pull/4217

kszucs avatar Jul 10 '22 13:07 kszucs

Test Results

       35 files         35 suites   1h 16m 31s :stopwatch:   8 996 tests   7 134 :heavy_check_mark: 1 857 :zzz:   5 :x: 32 934 runs  25 874 :heavy_check_mark: 7 043 :zzz: 17 :x:

For more details on these failures, see this check.

Results for commit 86fd3b87.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 10 '22 14:07 github-actions[bot]

Codecov Report

Merging #4219 (f328333) into 4.x.x (6b8a69f) will decrease coverage by 4.91%. The diff coverage is 89.65%.

:exclamation: Current head f328333 differs from pull request most recent head cfe341c. Consider uploading reports for the commit cfe341c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            4.x.x    #4219      +/-   ##
==========================================
- Coverage   92.86%   87.95%   -4.92%     
==========================================
  Files         180      178       -2     
  Lines       20161    19305     -856     
  Branches     2858     2840      -18     
==========================================
- Hits        18722    16979    -1743     
- Misses       1081     1966     +885     
- Partials      358      360       +2     
Impacted Files Coverage Δ
ibis/backends/base/sql/alchemy/__init__.py 89.71% <ø> (ø)
ibis/backends/clickhouse/compiler.py 0.00% <0.00%> (-87.50%) :arrow_down:
ibis/backends/clickhouse/registry.py 0.00% <0.00%> (-91.24%) :arrow_down:
ibis/backends/postgres/__init__.py 100.00% <ø> (ø)
ibis/backends/pyspark/__init__.py 84.21% <ø> (-0.37%) :arrow_down:
ibis/config.py 85.93% <ø> (-0.22%) :arrow_down:
ibis/expr/types/numeric.py 98.95% <ø> (-0.25%) :arrow_down:
ibis/expr/types/relations.py 91.60% <ø> (-2.19%) :arrow_down:
ibis/expr/types/sortkeys.py 100.00% <ø> (ø)
ibis/expr/types/strings.py 90.59% <ø> (-2.12%) :arrow_down:
... and 170 more

codecov[bot] avatar Aug 10 '22 18:08 codecov[bot]

@kszucs Can we close this out?

cpcloud avatar Sep 19 '22 15:09 cpcloud

Yes! I thought that I already closed it.

kszucs avatar Sep 19 '22 19:09 kszucs