ibis icon indicating copy to clipboard operation
ibis copied to clipboard

feat: add a simplified option for to_graph

Open djouallah opened this issue 1 year ago • 8 comments

Is your feature request related to a problem?

to_graph is really good but can be very hard to read for a complex transformation

What is the motivation behind your request?

I am just looking for a simple diagram that show relationship between tables and not show the details at the column level

Describe the solution you'd like

something less verbose for a lack of better word compared to the detailed output,

What version of ibis are you running?

9.3

What backend(s) are you using, if any?

duckdb, mssql and spark

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

djouallah avatar Sep 07 '24 14:09 djouallah

Thanks for the issue!

Can you show an example of what you're trying to get rid of or simplify?

cpcloud avatar Sep 09 '24 17:09 cpcloud

@turntable-justin @deepyaman Mentioned you had built something like this already.

cpcloud avatar Sep 09 '24 17:09 cpcloud

@turntable-justin @deepyaman Mentioned you had built something like this already.

@turntable-justin Actually, as I'm rereading this issue, I think I partially misunderstood the issue. 😅 That said, I don't 100% remember the level of detail on what you'd shown me on a text-based IR representation—if it was simpler, or if it was the full graph represented in text.

deepyaman avatar Sep 09 '24 17:09 deepyaman

basically something like this, I want to see only the relationship at the table level not the column level image

djouallah avatar Sep 09 '24 21:09 djouallah

Yeah ours is a representation of an IR that doesn't require graphviz and can just print in the terminal. Something like the below...

[image: Screenshot 2024-09-09 at 5.06.00 PM.png]

On Mon, Sep 9, 2024 at 5:00 PM Mimoune @.***> wrote:

basically something like this, I want to see only the relationship at the table level not the column level image.png (view on web) https://github.com/user-attachments/assets/ec00e292-b139-4bec-ad17-f55ffc0681e2

— Reply to this email directly, view it on GitHub https://github.com/ibis-project/ibis/issues/10054#issuecomment-2339228992, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HSLR3F2YNA6SUYBDUZ5F3ZVYK6RAVCNFSM6AAAAABN2BYDN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGIZDQOJZGI . You are receiving this because you were mentioned.Message ID: @.***>

turntable-justin avatar Sep 09 '24 22:09 turntable-justin

Yeah ours is a representation of an IR that doesn't require graphviz and can just print in the terminal. Something like the below... [image: Screenshot 2024-09-09 at 5.06.00 PM.png] On Mon, Sep 9, 2024 at 5:00 PM Mimoune @.> wrote: basically something like this, I want to see only the relationship at the table level not the column level image.png (view on web) https://github.com/user-attachments/assets/ec00e292-b139-4bec-ad17-f55ffc0681e2 — Reply to this email directly, view it on GitHub <#10054 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HSLR3F2YNA6SUYBDUZ5F3ZVYK6RAVCNFSM6AAAAABN2BYDN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGIZDQOJZGI . You are receiving this because you were mentioned.Message ID: @.>

@turntable-justin Don't think the image came through via email reply.

deepyaman avatar Sep 09 '24 22:09 deepyaman

Like below. Sorry about that!

Screenshot 2024-09-09 at 5 55 11 PM

turntable-justin avatar Sep 09 '24 22:09 turntable-justin

basically something like this, I want to see only the relationship at the table level not the column level image

I wonder how valuable this would be for most users? I'd expect, in most cases, you join a handful of tables together at most (there are some exceptions that come to mind, like when you join all of the input feature tables to create a master table for machine learning). If you're doing any sort of complicated logic, it's probably a good idea to represent these as inputs to a function, and then there are various tools (e.g. ML pipeline frameworks) that provide visualizations of these workflows. Not sure if Ibis needs to operate at this level?

deepyaman avatar Sep 09 '24 23:09 deepyaman