datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

Update valhalla.js Graphhopper to V7

Open mvanlaar opened this issue 1 year ago • 2 comments

Checklist

  • [ ] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [ ] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • [ ] The description lists all applicable issues this PR seeks to resolve
  • [ ] The description lists any configuration setting(s) that differ from the default settings
  • [ ] All tests and CI builds passing
  • [ ] The description lists all relevant PRs included in this release (remove this if not merging to master)
  • [ ] e2e tests are all passing (remove this if not merging to master)

Description

Version 7 of graphhopper api no longer supported vehicle, you have to use profile paramter instead.

See: https://github.com/graphhopper/graphhopper/blob/master/CHANGELOG.md

mvanlaar avatar May 03 '23 14:05 mvanlaar

Thanks for your work on this! Please let me know when you're ready for this to be reviewed. Don't worry about the e2e tests failing, it's because the PR originates from your repo

miles-grant-ibigroup avatar May 16 '23 12:05 miles-grant-ibigroup

You can review it now with the latest code. I change te code in the github online editor.

mvanlaar avatar May 16 '23 12:05 mvanlaar