datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

fix: support deployment summaries, speeding up deployments page

Open miles-grant-ibigroup opened this issue 2 years ago • 2 comments

Checklist

  • [x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • [x] The description lists all applicable issues this PR seeks to resolve
  • [x] The description lists any configuration setting(s) that differ from the default settings
  • [x] All tests and CI builds passing

Description

Makes use of https://github.com/ibi-group/datatools-server/pull/486. Speeds up the deployment page by not loading in entire deployment object for every entry. Also makes some updates to the mocked server to add a deployment summary endpoint.

miles-grant-ibigroup avatar Oct 14 '22 13:10 miles-grant-ibigroup

Have just run the e2e tests locally and they are failing, suggesting we need to fix the feed source columns

miles-grant-ibigroup avatar Oct 26 '22 12:10 miles-grant-ibigroup

Blocked pending feedSource endpoint updates on the backend.

miles-grant-ibigroup avatar Oct 26 '22 14:10 miles-grant-ibigroup

Updated to make use of new fields in https://github.com/ibi-group/datatools-server/pull/491. Will wait for e2e tests to pass and then assign to @binh-dam-ibigroup.

Even though the startDate field is missing, I have defaults set up so it shouldn't impact behavior (aside from the one edge case where the status label will fail to say that a feed which starts in the future starts in the future).

miles-grant-ibigroup avatar Nov 03 '22 15:11 miles-grant-ibigroup