datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

Published 20 hours ago • verified publisher icon ibi-group

I18N issues

Open hbruch opened this issue 2 years ago • 1 comments

Though some work regarding I18N already has been done, and I managed to create and apply a (yet incomplete) German translations file, there are still some places in the code and config, where I18N is still to be done (as already mentioned by @landonreed in #695).

While including translated messages for currently untranslated strings in components is work but mostly straight forward, I'm not quite sure regarding gtfs.yml. I currently think the text and helpContent should rather be messageIds and the actual text moved to the translation files (english.yml and others).

Another option would be to create localised gtfs.yml files, which would dulicate a lot of configuration data and might lead to inconsistencies in the long term.

Do you have a preference or better ideas and would such a change be accepted?

hbruch avatar Oct 07 '22 06:10 hbruch

Thanks so much for all this work! The approach of moving the gtfs.yml message IDs sounds reasonable to me. We welcome all new PRs and we'd love to support more languages.

Thanks again!

miles-grant-ibigroup avatar Oct 07 '22 12:10 miles-grant-ibigroup