datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

Published 20 hours ago • verified publisher icon ibi-group

Fix exception keys so that values do not reappear on deletion

Open philip-cline opened this issue 2 years ago • 2 comments

Checklist

  • [x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • [x] The description lists all applicable issues this PR seeks to resolve
  • [x] The description lists any configuration setting(s) that differ from the default settings
  • [x] All tests and CI builds passing

Description

Previously, issues with conflicting component keys were causing values to be transferred between exceptions mysteriously on deletion. This PR resolves that issue.

philip-cline avatar Aug 23 '22 19:08 philip-cline

I'm a little confused why the e2e tests are failing on the CI, they pass locally for me: image

philip-cline avatar Aug 24 '22 22:08 philip-cline

well they're passing now.. the x files theme plays in my head whenever I run these things

philip-cline avatar Aug 24 '22 23:08 philip-cline