datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

Don't ship 0 `departure_time` unless specified by user

Open miles-grant-ibigroup opened this issue 3 years ago • 1 comments

Checklist

  • [x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • [x] The description lists all applicable issues this PR seeks to resolve
  • [x] The description lists any configuration setting(s) that differ from the default settings
  • [x] All tests and CI builds passing

Description

Follow-up to https://github.com/ibi-group/datatools-ui/pull/836. Shipping a default 0 departureTime for pattern stop stop times is fine, but for pattern locations this cause unwanted behavior. This PR only ships 0 if the stop time is a pattern stop, otherwise it sends a null.

miles-grant-ibigroup avatar Aug 15 '22 17:08 miles-grant-ibigroup

Throwing a blocked on here until we figure out what's going on with these e2e tests

miles-grant-ibigroup avatar Aug 15 '22 17:08 miles-grant-ibigroup