datatools-ui
datatools-ui copied to clipboard
ibi-group
Config for 50m distance between stop location and shape ?
Observed behavior (please include a screenshot if possible)
In some cases (i.e. bus terminal with platforms that are out-of-reach for normal cars), we would like to have shape be close to stop location but default setting says 50m is max. Can this be configured ?
Hi @wkulesza, this is a best practices check (derived from here) and so can be ignored without serious issues arising. However, in a case like this we agree it would be reasonable to make the value configurable, especially given that the current canonical GTFS validator uses 100m rather than our 50m. We can take a look at adding a Project Setting for the max distance from stop to pattern shape.
@philip-cline thanks for getting back so quickly. Yes, I would like you to take a look and see if this could be configured in the config files. We could then also try and see what else we could bring up to config files and offer a PR in future.
I have checked and it is not currently configurable. Making the value configurable would be quite trivial. Here is the relevant line of code: https://github.com/ibi-group/datatools-ui/blob/4e7b8eac69fd14ae40b8a13ea86c3bf8b5e44691/lib/editor/constants/index.js#L21
We welcome new PRs!
@wkulesza It's also important to note here that this is really an indication that the stop should be probably be separated into child and parent stop IDs within the GTFS specification. From our perspective we would be interested to see some cases where this should be made configurable rather than adopting a child and parent stop relationship (although complexity with transit agencies will often make this difficult)
@philip-cline this stop is separated into stops and station since this is a bus terminal, but OBA doesn't support it fully yet. This bus terminal is located within the area of a railway station, which makes it even more exciting.