datatools-ui
datatools-ui copied to clipboard
Update 'publicly_available' and 'status' default values.
Description
Update the default values of status and publicly available feeds to be "Approved" and "Yes", respectively. This was just a simple change to the generateProps function in editor/util/gtfs.js to assign a value of 1 to publicly_visible, and 2 to status. This should better conform to user expectations for a new route.
resolves #589
Checklist
- [x] Appropriate branch selected (all PRs must first be merged to
dev
before they can be merged tomaster
) - [x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
- [x] The description lists all applicable issues this PR seeks to resolve
- [x] The description lists any configuration setting(s) that differ from the default settings
- [x] All tests and CI builds passing
New defaults:
Codecov Report
Merging #590 (67cd427) into dev (1061f1f) will increase coverage by
0.13%
. The diff coverage isn/a
.
:exclamation: Current head 67cd427 differs from pull request most recent head f708b56. Consider uploading reports for the commit f708b56 to get more accurate results
@@ Coverage Diff @@
## dev #590 +/- ##
==========================================
+ Coverage 15.67% 15.80% +0.13%
==========================================
Files 329 315 -14
Lines 16809 16100 -709
Branches 5066 4896 -170
==========================================
- Hits 2634 2545 -89
+ Misses 12124 11570 -554
+ Partials 2051 1985 -66
Flag | Coverage Δ | |
---|---|---|
unit_tests | 15.80% <ø> (+0.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
lib/editor/util/gtfs.js | 20.19% <ø> (ø) |
|
lib/admin/actions/admin.js | 18.88% <0.00%> (-2.12%) |
:arrow_down: |
lib/editor/actions/tripPattern.js | 16.66% <0.00%> (-1.08%) |
:arrow_down: |
lib/manager/util/version.js | 30.88% <0.00%> (-0.94%) |
:arrow_down: |
lib/editor/reducers/data.js | 9.94% <0.00%> (-0.47%) |
:arrow_down: |
lib/manager/reducers/status.js | 28.99% <0.00%> (-0.42%) |
:arrow_down: |
lib/manager/actions/versions.js | 12.71% <0.00%> (-0.27%) |
:arrow_down: |
lib/types/index.js | 0.00% <0.00%> (ø) |
|
lib/gtfs/util/graphql.js | 35.41% <0.00%> (ø) |
|
lib/common/util/config.js | 70.90% <0.00%> (ø) |
|
... and 66 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I will cherish this PR forever