datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

Manage OTP servers at the application level

Open landonreed opened this issue 7 years ago • 1 comments

Issue by landonreed Thursday Nov 15, 2018 at 19:12 GMT Originally opened as https://github.com/catalogueglobal/datatools-ui/pull/256


This is the UI PR to accompany catalogueglobal/datatools-server#124. It moves the management of OTP servers from the project settings to the site admin settings and allows servers to be optionally available to all projects in an application (or project specific). This also resolves #234, another deployment-related ticket.

This also fixes the merge project feeds job to conform with the standard approach of attaching just the ID of the related entity (project in this case) to the job JSON object, rather than the whole project object.


landonreed included the following code: https://github.com/catalogueglobal/datatools-ui/pull/256/commits

landonreed avatar Dec 10 '18 19:12 landonreed

Comment by codecov-io Thursday Nov 29, 2018 at 21:15 GMT


Codecov Report

Merging #256 into dev will decrease coverage by 0.05%. The diff coverage is 4.31%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev    #256      +/-   ##
========================================
- Coverage   4.92%   4.86%   -0.06%     
========================================
  Files        324     326       +2     
  Lines      15361   15542     +181     
  Branches    4636    4679      +43     
========================================
  Hits         756     756              
- Misses     12445   12589     +144     
- Partials    2160    2197      +37
Impacted Files Coverage Δ
lib/types/reducers.js 0% <ø> (ø) :arrow_up:
lib/types/index.js 0% <ø> (ø) :arrow_up:
lib/admin/components/UserAdmin.js 0% <0%> (ø) :arrow_up:
lib/manager/components/DeploymentSettings.js 0% <0%> (ø) :arrow_up:
lib/admin/actions/admin.js 0% <0%> (ø) :arrow_up:
lib/admin/containers/ActiveUserAdmin.js 0% <0%> (ø) :arrow_up:
lib/admin/reducers/servers.js 0% <0%> (ø)
lib/admin/components/ServerSettings.js 0% <0%> (ø)
lib/manager/util/deployment.js 0% <0%> (ø) :arrow_up:
lib/manager/components/DeploymentPreviewButton.js 0% <0%> (ø) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d8de35...c1dd3d5. Read the comment docs.

landonreed avatar Dec 10 '18 19:12 landonreed