datatools-ui icon indicating copy to clipboard operation
datatools-ui copied to clipboard

fix(graphhopper): Rename vehicle param to profile for routing requests with Graphhopper

Open marecabo opened this issue 3 months ago • 0 comments

Checklist

  • [x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • [x] The description lists all applicable issues this PR seeks to resolve
  • [x] The description lists any configuration setting(s) that differ from the default settings
  • [ ] All tests and CI builds passing [someone needs to trigger them]

Description

This fixes Street Snapping when editing shapes in the GTFS editor.

When I tried it with a local Graphhopper instance before, I got the error message "bad request: profile parameter required" from the routing request.

At some point, Graphhopper switched from a vehicle parameter to profile, see https://github.com/graphhopper/graphhopper/pull/1934 and https://github.com/graphhopper/graphhopper/blob/master/CHANGELOG.md#70-14-mar-2023

There is already a PR https://github.com/ibi-group/datatools-ui/pull/948 for updating this code, but it has not been edited since over two years. This edit aims to be minimally invasive to restore the routing functionality.

marecabo avatar Oct 04 '25 12:10 marecabo