Ian Bell

Results 624 comments of Ian Bell

Not sure what is going on here. @jowr any idea? I know that building the C# wrappers is tricky on non-windows platforms, and I think our new GitHub Actions-based builders...

It looks like you might be able to follow the pattern from: https://github.com/CoolProp/CoolProp/pull/2341

The short and snarky answer is: _don't worry about or use reference states_. Always start with properties that don't have a reference state in them (T,p,rho,q) and calculate the other...

But if you wanted to take the time to put together a pull request with that fixed, I would consider it.

+1 on this issue, stuck with exactly this problem

Are you sure both libraries are using the same reference states? That's the most likely culprit.

Could just be a bug in Refprop. What version do you use?

Never heard of this before. As CoolProp has very limited other dependencies (numpy only at runtime), I bet the other one is the culprit.

Can anybody dig in and figure out *why*? I have the intention to move to nlohmann::json as it is much more modern and rapidjson has not been updated in almost...

I have zero idea where to look, but the common denominator does seem to be rapidjson. Can anyone file a PR fixing this somehow?