Ian Bell
Ian Bell
This is amazing!! I have known of this problem for a long time now, but didn't have the bandwidth to do anything about it. Can you also double-check that you...
What does your picture look like after your fix? If complete, I'll merge. Overall your fixes seem reasonable from my looking at it.
Ok, let's merge this and then if you want to dig into the DQ that would be great. The DQ routines in REFPROP also fail sometimes.
1), 2), 3) should all yield exception in C# (R290 is not a valid identifier in REFPROP) 4) should be ok because your input is 300 kPa, if I understand...
For 4), it works because your input argument is temperatureCompIn rather than PPP. If I understand correctly, that is. > Message ID: ***@***.***> >
I think this is a bug in Refprop, you should get an out of range error
The viscosity model in CoolProp is only very, very approximate. You should not trust it, or use it. Entropy scaling options are a better bet. > Message ID: ***@***.***> >
Actually there is a third way which should be the "right" answer. Take the critical density and temperature to obtain the pressure and compressibility factor. The value from the Wagner...
A further point is that the EOS for Wagner and Pruss for water is non-analytic - you cannot evaluate it at the critical point. So you should bump the temperature...
Yes I would, because those values are not necessarily the same as used for the EOS. Always safest to use the EOS. In most cases the differences between methods should...