bouncer icon indicating copy to clipboard operation
bouncer copied to clipboard

adding :max_age as a parameter for verify

Open girishramnani opened this issue 6 years ago • 12 comments

currently without the :max_age parameter every Phoenix.Token.verify call prints an warning. Issue https://github.com/phoenixframework/phoenix/issues/2868

So added a config parameter :max_age ( default 86400 i.e. seconds in a day ) in bouncer which can be used to configure the value.

girishramnani avatar May 27 '19 11:05 girishramnani

Thanks, can you get the tests passing?

ianwalter avatar May 29 '19 20:05 ianwalter

sure, I will go over it

girishramnani avatar May 30 '19 11:05 girishramnani

I have tests passing locally

Finished in 0.6 seconds
11 doctests, 24 tests, 0 failures

there are not logs showing up on semaphoreCI @ianwalter

girishramnani avatar May 30 '19 11:05 girishramnani

any updates @ianwalter ?

girishramnani avatar Jun 15 '19 19:06 girishramnani

Tests fail for me locally and havent had a chance to look into why.

ianwalter avatar Jun 15 '19 22:06 ianwalter

if you can share the local setup that you are using or even semaphore is using I can try to reproduce the error locally @ianwalter

girishramnani avatar Jul 20 '19 13:07 girishramnani

I have setup my own semaphore CI and was able to make it pass on elixir 1.3.4 https://semaphoreci.com/girishramnani/bouncer. But surprisingly this PR is still failing. any help @ianwalter would be highly appreciated

girishramnani avatar Aug 05 '19 07:08 girishramnani

@ianwalter could you please take a look?

girishramnani avatar Sep 08 '19 14:09 girishramnani

Sorry it took me a while to get to this @girishramnani. I moved CI to GitHub actions. Can you pull in master?

ianwalter avatar Oct 24 '19 02:10 ianwalter

Sure

On Thu, 24 Oct 2019, 08:19 Ian Walter, [email protected] wrote:

Sorry it took me a while to get to this @girishramnani https://github.com/girishramnani. I moved CI to GitHub actions. Can you pull in master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ianwalter/bouncer/pull/22?email_source=notifications&email_token=ABR7TNFUJYCFQCEPDYG43FTQQEEMTA5CNFSM4HP27ZM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECDQBPA#issuecomment-545718460, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABR7TNAIEIOVDH5HKGOA7FDQQEEMTANCNFSM4HP27ZMQ .

girishramnani avatar Oct 24 '19 05:10 girishramnani

@ianwalter rebased

girishramnani avatar Oct 24 '19 20:10 girishramnani

@ianwalter it seems that the Github Action CI job passed. could you please take a look?

girishramnani avatar Dec 19 '19 09:12 girishramnani