adding :max_age as a parameter for verify
currently without the :max_age parameter every Phoenix.Token.verify call prints an warning. Issue https://github.com/phoenixframework/phoenix/issues/2868
So added a config parameter :max_age ( default 86400 i.e. seconds in a day ) in bouncer which can be used to configure the value.
Thanks, can you get the tests passing?
sure, I will go over it
I have tests passing locally
Finished in 0.6 seconds
11 doctests, 24 tests, 0 failures
there are not logs showing up on semaphoreCI @ianwalter
any updates @ianwalter ?
Tests fail for me locally and havent had a chance to look into why.
if you can share the local setup that you are using or even semaphore is using I can try to reproduce the error locally @ianwalter
I have setup my own semaphore CI and was able to make it pass on elixir 1.3.4 https://semaphoreci.com/girishramnani/bouncer. But surprisingly this PR is still failing. any help @ianwalter would be highly appreciated
@ianwalter could you please take a look?
Sorry it took me a while to get to this @girishramnani. I moved CI to GitHub actions. Can you pull in master?
Sure
On Thu, 24 Oct 2019, 08:19 Ian Walter, [email protected] wrote:
Sorry it took me a while to get to this @girishramnani https://github.com/girishramnani. I moved CI to GitHub actions. Can you pull in master?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ianwalter/bouncer/pull/22?email_source=notifications&email_token=ABR7TNFUJYCFQCEPDYG43FTQQEEMTA5CNFSM4HP27ZM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECDQBPA#issuecomment-545718460, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABR7TNAIEIOVDH5HKGOA7FDQQEEMTANCNFSM4HP27ZMQ .
@ianwalter rebased
@ianwalter it seems that the Github Action CI job passed. could you please take a look?