is-hotkey icon indicating copy to clipboard operation
is-hotkey copied to clipboard

Added ability to be used using a switch statment (#46)

Open samyosm opened this issue 2 years ago • 3 comments

Description

I added a toHotkeyName and a getHotKeyName function in order to convert an event to a hotkey name that can then be used inside a switch statement.

I also took the time to add the necessary documentation though it might not be fully complete as I didn't describe the toHotKeyName function.

Fixes #46

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Documentation update

How To Verify?

If you would like, you could test this feature in this sandbox.

samyosm avatar Aug 23 '22 10:08 samyosm

@osmium-dev thank you, this is a really cool idea!

Can you add a few tests to ensure this stays working going forward? Thanks!

ianstormtaylor avatar Sep 19 '22 16:09 ianstormtaylor

I would love these, @samyosm can you please, also add the tests so that @ianstormtaylor can merge :)

aifrim avatar Nov 10 '22 10:11 aifrim

@osmium-dev thank you, this is a really cool idea!

Can you add a few tests to ensure this stays working going forward? Thanks!

I added a few tests, I'm not sure they pass thought.

samyosm avatar Nov 27 '22 23:11 samyosm