Ian Samuel

Found value has wrong type, expects a Hash value, got Tuple

1

https://github.com/voxpupuli/puppet-php/blob/bb5755fc6e726686c891b9ec9e0e6802f2ccc932/manifests/fpm.pp#L103 If I'm reading this correctly, Strategy => Unique returns an array, but the returned value needs to be a Hash. https://puppet.com/docs/puppet/latest/hiera_merging.html#unique Probably a stategy of 'Deep' is intended here...

Need additional logic for Postfix v3 on Debian and Ubuntu

2

The daemon_directory path has changed with v3, and the module should account for that. I used the following work-around for Ubuntu Xenial: ``` if $::operatingsystem == 'Ubuntu' and versioncmp($::operatingsystemrelease,'16.04') >=0...