Ian Sinnott

Results 134 comments of Ian Sinnott

> any updates on this guys? Nope, but I'd be happy to merge a PR if anyone wants to open one.

Can you elaborate on this? I'm not sure what bug you're seeing based on the description

Can you post the code? I don't see any anchor tags in the example in your first comment.

@debojyotighosh thanks, that makes sense 👍 Could you add a test to make sure the indexes are passed as expected? Test file: https://github.com/iansinnott/react-string-replace/blob/master/test.js

Also, why are you using `parseInt`?

Do you have an example regex? This library depends on the functionality of `String.prototype.split` which will place matched characters in odd-numbered elements of a split array: ```js 'hey you there'.split(/(...

Hey @CaptainStiggz, yeah this lib does not handle nested replacements. The reason being, it's meant to be roughly equivalent to `String.prototype.replace` in it's functionality, however, it is true that we...

You might consider using the `React.Children` API for the recursion in this case, since it will handle children regardless of whether it's a single element or an array. You would...

Yeah, the duplication makes me uncomfortable as well because it's the entire file. If we want to change _anything_ at all we'll have to change it in two places and...

Maybe you're right about just using babel. This is meant for react apps so whoever is importing this lib will probably have some kind of build pipeline set up. If...