MMM-Formula1 icon indicating copy to clipboard operation
MMM-Formula1 copied to clipboard

Las Vegas Grand Prix Wrong Date, Ergast API deprecated

Open efkann opened this issue 1 year ago • 7 comments

Screenshot 2024-11-22 at 23 04 35

I just realized the dates of Las Vegas weekend are wrong.

Is this only me or also shows wrong date for you ?

By the way, Ergast API is deprecated and I think we should consider moving over to Jolpica which provides Ergast compatible API

efkann avatar Nov 22 '24 20:11 efkann

https://github.com/ianperrin/MMM-Formula1/blob/0728d7e76b432a7012855c7d330a1ebc3b1761cf/node_helper.js#L38-L40

I just changed f1Url to

var f1Url = "https://api.jolpi.ca/ergast/f1/" + season;

Started showing the correct date for Las Vegas.

efkann avatar Nov 22 '24 20:11 efkann

We will look into Jolpica after this season.

Happy to see that doesn't break the code

73cirdan avatar Dec 02 '24 09:12 73cirdan

Ergast is down during almost the whole day now. Currently testing jolpi to see if its ok. Any feedback on using jolpi is welcome.

For me it seems to work very good.

If ergast stays down I will patch in this week

73cirdan avatar Dec 02 '24 16:12 73cirdan

I do see the points are still up until round 22. las vegas. Qatar is not yet in the standings?

73cirdan avatar Dec 02 '24 16:12 73cirdan

I do see the points are still up until round 22. las vegas. Qatar is not yet in the standings?

Check out Jolpica's repo.

Also there's a section for differences with Ergast API

efkann avatar Dec 02 '24 17:12 efkann

today I made some provisional changes for the next season in branch "devjan2025"

  • switched to new jolpi.ca api
  • checked the 2025 schedule for new races (none) so now new track layout necessary
  • prepared some code for a breaking change around sprint qualifying definition

The schedule data for 2025 is not yet available. So, hard to test if other breaking changes occur

73cirdan avatar Jan 02 '25 12:01 73cirdan

As you said, we should revisit it once the full 2025 schedule is out to address any potential issues. But for now, it looks like a good start.

efkann avatar Jan 02 '25 13:01 efkann