meteor-accounts-ui-bootstrap-3 icon indicating copy to clipboard operation
meteor-accounts-ui-bootstrap-3 copied to clipboard

Published 20 hours ago • verified publisher icon ianmartorell

"Forgot password" email link doesn't show "Reset Password" modal

Open pcoady opened this issue 10 years ago • 10 comments

When I use 'forgot password' the email link eg "http://mydomain.com/#/reset-password/fpfVy5s6Q74I7U8e_H-n5EM2Y3I5DdOzFi9ViliDjFU" just redirects to "http://mydomain.com/#/" without showing the reset password modal.

pcoady avatar Apr 28 '15 10:04 pcoady

Do you still have this issue? It works fine for me.

ianmartorell avatar Jun 25 '15 19:06 ianmartorell

@ianmartorell: I have just discovered your package and it looks great. Maybe there is something I don't understand, but here the OP is asking what should happen when entering the "reset" URL in his browser address bar. Am I wrong to say that, because your package doesn't integrate with a router, nothing will happen? In other words, it is up to the programmer to implement the actual "reset password" logic, isn't it?

steph643 avatar Jul 11 '15 10:07 steph643

Looking at the code, I discovered there is indeed some logic to display a reset password modal. However I confirm the present issue: most of the time, the modal does not show up.

steph643 avatar Jul 11 '15 10:07 steph643

When using the reset url:

  • Accounts._resetPasswordToken contains the proper token.
  • Accounts._loginButtonsSession.get('resetPasswordToken') contains the proper token.
  • <body> contains the proper modal (with display:none).

Additionally, when I play with my app a lot and change my code (triggering hot code push), the modal sometimes shows up, but I didn't find a way to reproduce this every time.

steph643 avatar Jul 11 '15 21:07 steph643

If outer is the template that uses {{> loginButtons}}, adding the following code fixes the problem:

Template.outer.rendered = function() {
  $('#login-buttons-reset-password-modal').modal();
};

steph643 avatar Jul 11 '15 22:07 steph643

I also have this issue, on 1.2.84 and as well on 1.2.89. @steph643 's solution (even using onRendered) has no effect. I do seem to have a display:none dialog in my dom with id = login-buttons-reset-password-modal-success. I don't have a dialog in my dom with id = login-buttons-reset-password-modal

dpatte avatar Feb 13 '16 04:02 dpatte

I was having this issue also. But in fact was a conflict with modals between semantic-ui and bootstrap. After removing semantic-ui dependency the recovering functionality started to work as expected.

vjrj avatar Jun 24 '16 09:06 vjrj

Still have this isssue. I decided to dig deeper.

  1. I do have a dialog in my dom with id = login-buttons-reset-password-modal-success . it is hidden. I also have a div with id = login-buttons-reset-password-modal, but there is nothing within the div
  2. When I use the email link, in url_client, part of accounts-base, self._accountsCallbacks[urlPart] seem to be undefined, so the handler doesnt get called, which I presume would show the dialog we all would like.
  3. i am using bootstrap dialogs elsewhere in my app and they work.

@vjrj , can you please tell me the order of your packages in your .meteor/packages file?

dpatte avatar Jul 17 '16 05:07 dpatte

@dpatte https://github.com/comunes/bebes-robados/tree/master/.meteor

vjrj avatar Jul 18 '16 08:07 vjrj

+1 - I actually cannot find the login-buttons-reset-password-modal element anywhere

sunlee-newyork avatar Sep 26 '17 15:09 sunlee-newyork