elm-geometry icon indicating copy to clipboard operation
elm-geometry copied to clipboard

Published 20 hours ago • verified publisher icon ianmackenzie

Add more fuzz tests for point/vector/direction functions

Open ianmackenzie opened this issue 4 years ago • 2 comments

The Point#d, Vector#d and Direction#d modules were recently optimized in the coordinate-systems branch to avoid unnecessary object allocations and function calls, but this also meant most functions got more verbose and therefore more prone to typos. It would be very useful to add some more fuzz and/or hardcoded tests for the various functions in these modules, following the patterns in the existing Tests.Point3d etc. test modules. ~~Please make sure you make any PRs against the coordinate-systems branch!~~

ianmackenzie avatar Jul 23 '19 12:07 ianmackenzie

Just found one such typo bug myself and added a couple of tests for it: https://github.com/ianmackenzie/elm-geometry/commit/5065e5db05c46b1e64684dafb8e83cea4d4880d3

ianmackenzie avatar Jul 24 '19 02:07 ianmackenzie

Update: the coordinate-systems branch has been merged back into master and no longer exists, so please make any PRs against master instead.

ianmackenzie avatar Sep 30 '19 14:09 ianmackenzie