libbacktrace icon indicating copy to clipboard operation
libbacktrace copied to clipboard

Avoid failing early when we cannot find symbols on macho

Open tkonolige opened this issue 4 years ago • 4 comments

I've been hitting this issue on macOS where backtrace errors out early even though it can still find symbols for some libraries. This happens when I am loading my library dynamically from python, so I assume its some python libraries that are causing issues.

I'm not quite sure if the logic here is correct. It works in my use cases, but I think I need someone who knows the codebase to verify it is correct.

tkonolige avatar Dec 16 '20 23:12 tkonolige

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Dec 16 '20 23:12 googlebot

@googlebot I signed it!

tkonolige avatar Dec 16 '20 23:12 tkonolige

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Dec 16 '20 23:12 googlebot

@ianlancetaylor Could you take a look at this. Its a pretty simple fix.

tkonolige avatar Mar 16 '21 17:03 tkonolige