xfs_undelete icon indicating copy to clipboard operation
xfs_undelete copied to clipboard

thank and suggest

Open arliweng opened this issue 2 years ago • 2 comments

thank u for great tool, two suggest, 1, i change the filename by ctime to mtime, unlike ext4 have directory name, so mtime is only mark of what it's.. hope an option for use the ctime or mtime as file name. or restore the file's mtime(in code current not) 2, i put an size filter, many not .c but named .c file recover more 10G.. so very slow. hope an option for that, just $loffset*$::blocksize maybe. i change the code but i don't known about tclsh, i just sample copy many if todo that, so i don't pull the request, just suggests.

arliweng avatar Sep 20 '22 19:09 arliweng

You are right, using mtime instead of ctime for the filenames makes more sense. That code is from the original version which did not consider mtime and thus, did not retrieve it from the inode.

About the size filter, that's only for sorting out bogus files, right? Okay, it's easy to sort out all 10GB files as most likely bogus but it would be more useful to be able to sort out bogus 100 MB files as well. For the latter, it had to guess the file type earlier in the process. I have to think about that first.

ianka avatar Oct 01 '22 01:10 ianka

I thought about it again, and I wonder if using mtime for the filename is really better. Usually people would know when they accidentally deleted the file (ctime) rather than when it was last updated (mtime).

ianka avatar Oct 02 '22 15:10 ianka