jupyterlab-vimrc icon indicating copy to clipboard operation
jupyterlab-vimrc copied to clipboard

Add Conda Feedstock

Open marcelteraflow opened this issue 3 years ago • 11 comments

For those who use the conda build system, is there a conda-forge feedstock?

marcelteraflow avatar Nov 30 '22 16:11 marcelteraflow

Apparently I started the process back in march and it never got through: https://github.com/conda-forge/staged-recipes/pull/18223

I think i'll reopen and ping. Thanks!

ianhi avatar Nov 30 '22 16:11 ianhi

Ah it looks as though the build failed and I didn't know why. If it fails again I'm now even further removed from understanding building pyhton x typescript packages so here's hoping it's not too tricky to solve

ianhi avatar Nov 30 '22 16:11 ianhi

https://github.com/conda-forge/staged-recipes/pull/21385

marcelteraflow avatar Nov 30 '22 16:11 marcelteraflow

Please see my attempt. I'm willing to amend my PR to make you maintainer.

marcelteraflow avatar Nov 30 '22 16:11 marcelteraflow

This package is amazing and I'm tired of having it be the only package under "install with pip" section in my environment.yml

marcelteraflow avatar Nov 30 '22 16:11 marcelteraflow

Perhaps a good idea would be to add a meta.yml to the repo so it stays up to date? I'm not sure whether my pull request will stay up to date with the pypi version.

marcelteraflow avatar Nov 30 '22 16:11 marcelteraflow

thanks for taking the initiative! the build still fails unfortunately, likely because it's been a long time since I updated the build scripts for this package, and they are significantly out of date with the modern jupyterlab-extension build system. It should be updated to follow the current state of https://github.com/jupyterlab/extension-cookiecutter-ts

ianhi avatar Nov 30 '22 17:11 ianhi

Please see my attempt. I'm willing to amend my PR to make you maintainer.

yes please

Perhaps a good idea would be to add a meta.yml to the repo so it stays up to date? I'm not sure whether my pull request will stay up to date with the pypi version.

Maybe I'm misunderstanding your concern, but once the PR is accepted it will be moved to a diffrent conda forge repo and a bot will autodetect pushes to pypi and update conda-forge.

ianhi avatar Nov 30 '22 17:11 ianhi

re the build system, I have experiments to run today, but towards the end of the week iwll likely have some time to look into it. Of course if you feel particularly inspired I'd also be happy to accept PRs that successfully update to the new system.

ianhi avatar Nov 30 '22 17:11 ianhi

yes please

https://github.com/conda-forge/staged-recipes/pull/21385/commits/9bc1a06dd4cbd7250a8d96544ac37edf13bc5e14

marcelteraflow avatar Nov 30 '22 17:11 marcelteraflow

Yeah I'm also still getting build errors. As you can conclude I'm a heavy user of the conda infrastructure but haven't maintained packages myself.

I'll leave my pull request for now and let you focus on yours.

I checked the build logs for linux

Don't know if you have tried to comb through the linux64 raw logs?

marcelteraflow avatar Nov 30 '22 17:11 marcelteraflow