jupyterlab-vimrc icon indicating copy to clipboard operation
jupyterlab-vimrc copied to clipboard

In jupyterlab>=3.1 shift+enter with this extension changes mode to jupyter command mode

Open filyp opened this issue 3 years ago • 5 comments

This only happens with this extension enabled. It works well for jupyterlab==3.0.0, only breaks for >=3.1.

Other extensions installed:

JupyterLab v3.1.12
/home/filip/.local/share/jupyter/labextensions
        jupyter-matplotlib v0.8.3 enabled OK
        jupyter-vue v1.5.0 enabled OK
        jupyterlab_autosave_on_focus_change v0.1.2 enabled OK (python, jupyterlab_autosave_on_focus_change)
        jupyter-vuetify v1.8.1 enabled OK
        @aquirdturtle/collapsible_headings v3.0.1 enabled OK (python, aquirdturtle_collapsible_headings)
        @ryantam626/jupyterlab_code_formatter v1.4.10 enabled OK (python, jupyterlab-code-formatter)
        @pyviz/jupyterlab_pyviz v2.1.0 enabled OK (python, pyviz_comms)
        @axlair/jupyterlab_vim v0.13.0 enabled OK (python, jupyterlab_vim)

Other labextensions (built into JupyterLab)
   app dir: /home/filip/.local/share/jupyter/lab
        @arbennett/base16-gruvbox-dark v0.1.5 enabled OK
        @arbennett/base16-nord v0.1.5 enabled OK
        @jupyter-widgets/jupyterlab-manager v3.0.0 enabled OK

filyp avatar Sep 16 '21 14:09 filyp

:( that sounds like no fun to deal with. Can you post the contents of your vimrc file?

ianhi avatar Oct 12 '21 03:10 ianhi

Here:

{
"imap": 
    [
        ["kj", "<Esc>"],
        ["jk", "<Esc>"],
    ],
        
"nmap":
    [
        ["J", "<C-d>"],        
        ["K", "<C-u>"],        
    ],

    // set unnamedplus
    // If true, yanking without specifying a register will also yank to the system clipboard.
    "unnamedplus": true,
}

I also checked, that the same thing happens with an empty vimrc. Also, just checked that it still happens with the latest jupyterlab (3.1.18).

filyp avatar Oct 12 '21 10:10 filyp

I can't replicate this with:

JupyterLab v3.2.0rc0
/home/ian/mambaforge/envs/vim-test/share/jupyter/labextensions
        jupyterlab-vimrc v0.5.2 enabled OK
        @axlair/jupyterlab_vim v0.14.5 enabled OK (python, jupyterlab_vim)

Your version of jupyterlab-vim is a bit out of date so maybe that could be the issue.

Can you also see if these steps for test env replicate it for you?

conda create -n vim-test -c conda-forge python
conda activate vim-test
pip install --upgrade jupyterlab jupyterlab-vim jupyterlab-vimrc

ianhi avatar Oct 14 '21 02:10 ianhi

Hmm, I still have this problem with the steps you mentioned. I even reinstalled the whole jupyter stack, and cleared all my configuration. Now all I have is:

JupyterLab v3.2.0
/home/filip/.local/share/jupyter/labextensions
        @axlair/jupyterlab_vim v0.14.5 enabled OK (python, jupyterlab_vim)

And installing jupyterlab-vimrc still causes this problem.

filyp avatar Oct 20 '21 12:10 filyp

But if I'm the only one getting this problem, it must something wrong with my environment.

filyp avatar Oct 20 '21 12:10 filyp