health_check icon indicating copy to clipboard operation
health_check copied to clipboard

Ignoring only specific custom checks

Open DannyBen opened this issue 6 years ago • 0 comments

I am installing and configuring this lovely gem now, and bumped into a small issue, which I guess is by design, so (if I am right) I would like to propose a change.

Doing this in my healthcheck config:

config.add_custom_check('events') { Event.health_check }
config.standard_checks -= [ 'events' ]

I expected that this named custom check will be excluded. It didn't. The only way for me to exclude it, was to do this:

config.standard_checks -= [ 'custom' ]

Although it is not a big deal for me, since I currently have only one custom check, I would have liked to be able to exclude or include named custom configs separately, and not only as a custom group.

EDIT

Since writing this issue, my need for separate custom issues have grown. I want to include one of my custom tests in the standard tests, and not include the other.

For the sake of example, lets assume I have a custom check named "include_me" and one called "exclude_me".

So far, weirdly enough, this works:

config.standard_checks = %w[site database include_me]

While this, does not work (I am getting all tests, including the two custom ones):

config.standard_checks -= %w[exclude_me]

Am I missing something?

DannyBen avatar Jun 24 '18 09:06 DannyBen