stats_can icon indicating copy to clipboard operation
stats_can copied to clipboard

Update tables doesn't check for file existence

Open ianepreston opened this issue 6 years ago • 1 comments

Probably other functions too. At least update_tables doesn't. Noticed it in the StatsCan class, but this should be fixed at the function level

ianepreston avatar Nov 19 '19 18:11 ianepreston

Hi @ianepreston, I've been handling this through simply excepting a FileNotFoundError but have also run into a couple of ConnectionErrors recently. I haven't been able to isolate if it's my VPN, ISP, StatCan's servers, or what.

Anyways, not sure if that's the best way to deal with this through the package but happy to try and make a PR using my implementation.

jasonrwang avatar Oct 15 '24 20:10 jasonrwang