Ian Dunn

I'm gonna close this because it looks like a duplicate of #255 / #239, but let me know if there's anything distinct that I missed.

> WPCS still requires longhand array syntax, so that's the code suggestions I've made here. There was [a proposal](https://make.wordpress.org/core/2019/03/26/coding-standards-updates-for-php-5-6/) to change to the short syntax, but [the decision](https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/) was to...

U2F is deprecated and no longer works in Chrome, so the provider is being removed in #439 . Given that, there's probably no reason to keep this open anymore.

IMO, it'd be best to use a JavaScript library, so that we're not running a bunch of 3rd party code on the server unnecessarily. The library mentioned in #42 seems...

I tested this (as of 4b5513f) w/ Firefox Dev Edition `106` and Chrome `105`, with a Yubikey 5C NFC and a Yubikey 5C Nano. It worked in all cases 👍🏻

I apologize for raising this late in the process, but I've been looking at this closer and have some concerns: * There aren't any tests (here or upstream) for the...

I agree that getting `0.8` out the door soon is important 👍🏻 If we want to [migrate U2F keys](https://github.com/WordPress/two-factor/pull/439#issuecomment-1279366113), then the bare minimum we'll need to do is switch to...

Migrating the keys is awesome 🎉 A separate PR seems better to me, to help keep things manageable 👍🏻 What are your thoughts on removing the `2tvenom/cborencode` and `davidearl/webauthn` libraries,...

@mcguffin you've raised some good points 🤔 I also wish that there was a more mature & popular library, but unfortunately it doesn't look like that exists yet. It seems...

That one does look mature and well tested too 🤔 IIRC @sjinks tried it out for his plugin and found that [the easy way](https://webauthn-doc.spomky-labs.com/v/v3.3/the-webauthn-server/the-easy-way) didn't support U2F migration, and [the...