Ian Czekala
Ian Czekala
You're right about the need to flux-standardize (_not_ continuum-normalize) the input grid, this is to remove the largest source of variance in the models so that the emulation is more...
Hrm, that's strange. The reason why `parallel.py` and `star.py` looked the way they did was to avoid the pickling issue. I looked through the commit history and there was nothing...
Ok that's pretty strange. I've done all my developing and testing on Arch Linux, if that helps as a point of reference.
Thanks for the thoughtful feedback. You bring up a good point about already using JSON to store the sub-parameters for each order. One thing that I would love to address...
I drafted a format that uses JSON over at https://github.com/iancze/EchelleJSON For a use case, check out `test.py`.
I think this might be an issue of what `t_0` corresponds to. If you set `t_periastron=0` in `xo.orbits.KeplerianOrbit`, do things make sense? I think the `t_0` is for a reference...
I think I might know what be going on... the orbital convention figure should probably be updated. I am assuming that you are talking about [this one](https://docs.exoplanet.codes/en/latest/_images/orbit3D.png) defined in the...
Thanks for your help digging into these inconsistencies. We didn't completely follow the conventions in Murray and Correia. In particular, we explicitly chose the ascending node convention (orbiting object crosses...
Great! I'm glad we identified the source. Re: `Omega`, I believe this variable should be the same for both the primary and secondary, since both objects will orbit in the...
Looks nice! The original figure is an SVG file I created using shapes in Inkscape, and, as #212 revealed, could certainly be improved/replaced. After making that figure, I came to...