python-iwlist icon indicating copy to clipboard operation
python-iwlist copied to clipboard

Published 20 hours ago • verified publisher icon iancoleman

Add network type; ['WPA', 'WPA2', 'WEP', 'Open'], export to CSV, bug in signal level

Open SlowBro904 opened this issue 7 years ago • 4 comments

I actually have this code working. How can I contribute it back to this useful project? I am only an intermediate programmer so I'd welcome improvements.

Also my code is only aimed at non-technical home users. I didn't look into adding network types for enterprise. So it's not for everyone.

I changed the signal level regex so that the 'db' now is signal level, and not "Quality level," and also there was a bug in this regex, at least on a Raspberry Pi. If it does not work for all devices perhaps two regex should be provided; but I noticed no 'db' on the Readme.md so I gather it's a bug for every device. I found the "Signal level" from iwlist (what you labelled 'db') to be relevant and "Quality level" to not be relevant at all. So I fixed the regex bug and made it the only selection, ignoring Quality. If I am mistaken please let me know. iwlist.py.txt

SlowBro904 avatar Mar 05 '17 14:03 SlowBro904

Thanks for this.

I've been meaning to revise the fields used in this project, since I gather iwlist is fairly inconsistent across platforms and devices. Having it work reliably in a variety of situations will be good.

Your contribution with this issue will help with that task, so thanks for contributing.

If you would like to learn the 'best' way to contribute, you should read about github pull requests. But the way you've done it in this issue is fine for this particular project!

iancoleman avatar Mar 11 '17 09:03 iancoleman

Thanks for this. You make a good point about the naming of signal level / quality. Your way is much more consistent with the output from iwlist.

The naming of these values has been changed in https://github.com/iancoleman/python-iwlist/commit/a74fad374b3b9ec0dc593ff835fc99883dd7119d

If you have a copy of some output from iwlist that doesn't work well with this parser I would appreciate a copy of it so I can duplicate the issue and add regression tests.

Thanks again for reporting this and sorry for the long time to attend to it!

iancoleman avatar Jun 16 '17 05:06 iancoleman

Can you or would you add the encryption details to this script?

dachshund-digital avatar Mar 15 '18 00:03 dachshund-digital

See related pull request https://github.com/iancoleman/python-iwlist/pull/6

iancoleman avatar May 07 '18 05:05 iancoleman