Ian Costanzo

Results 223 comments of Ian Costanzo

I'm still doing some testing, but overall looks good! Just a few minor comments ... A couple of things we need: - updates to documentation - a reference in the...

> I would really like to see at least an interactive run of using Credo-TS as a holder, and using ACA-Py as an issuer and verifier. Crucial for the CWU...

I ran a quick test of the alice/faber demo and it failed. I did the `./run_demo build ...` on each agent and then: Faber: `$ AGENT_PORT_OVERRIDE=8010 ./run_demo run faber --wallet-type...

... also when I run the integration tests they all report as "pass" but when I look through the logs there are errors: ``` $ AGENT_PORT_OVERRIDE=8030 ./run_bdd -t @T003-RFC0453 ......

Running the alice/faber demo with the `--events` flag I can see that alice receives the credential offer and sends the credential request, and faber gets the error receiving the request....

> I created issue #2923 for this — I think it is an urgent one for 0.12.1. An qualified DID is being used by Alice, being sent in the `request`...

> @ianco when you take a look at this, my thought is if the code is correct and passing the current integration tests, we should merge this PR before it...

Is this for traction or aca-py? It sounds like the issue is with log messages that are logged by aca-py, but does aca-py know the tennant_id?

> This _might_ possibly be covered under [tracing](https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/AgentTracing.md) Does AFJ/Bifold support message tracing?

There are a few test processes that we use: - aca-py unit tests, which tend to be rather brittle for certain types of code changes, that test "units" of code...