exif-py icon indicating copy to clipboard operation
exif-py copied to clipboard

fix webp for file conversion by magick

Open mvaranda opened this issue 5 years ago • 5 comments

This fix is working for my use-case: files converted using magick tool. However, I believe that the original code was working for other EXIF formats.

Need regression test and, maybe, process EXIF according to its verion.

mvaranda avatar Nov 08 '20 15:11 mvaranda

Thank you. I'm having some problems with travis on this repo, will take a better look when fixed.

ianare avatar Nov 09 '20 22:11 ianare

For testing, the following link is the exif-samples/jpg/gps/DSCN0010.jpg converted to web using imageMagick 7.0.10:

https://drive.google.com/file/d/1lUqCjwB-O0NW5r2D7f7ougsV5RS5Ipxh/view?usp=sharing https://drive.google.com/file/d/1lUqCjwB-O0NW5r2D7f7ougsV5RS5Ipxh/view?usp=sharing

Cheers, Marcelo

On Nov 9, 2020, at 5:35 PM, ianaré sévi [email protected] wrote:

Thank you. I'm having some problems with travis on this repo, will take a better look when fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ianare/exif-py/pull/132#issuecomment-724319526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABARZ6NAHZXDU4YRIEXH2XDSPBVELANCNFSM4TOMVSDQ.

mvaranda avatar Nov 09 '20 23:11 mvaranda

Sorry for the delay, finally got everything working. Can you rebase develop onto this branch? Thank you.

ianare avatar Apr 22 '21 10:04 ianare

I am not able to test as my scripts were in my bz laptop and I move jobs. I may have somewhere a copy but will nee to dig. Anyways... I do not see the line 50 in exifread/init.py having the proposed fix:

https://github.com/ianare/exif-py/pull/132/commits/e5d057807418d5b3a07611b0217bdbf36761a499

mvaranda avatar Apr 22 '21 11:04 mvaranda

OK no worries I will take care of it.

ianare avatar Apr 22 '21 12:04 ianare