next-sitemap icon indicating copy to clipboard operation
next-sitemap copied to clipboard

created google news, image and video support

Open zuffik opened this issue 2 years ago • 3 comments

References: #110

zuffik avatar Jul 10 '22 09:07 zuffik

Is this something that could go live @iamvishnusankar ?

cipriancaba avatar Aug 01 '22 09:08 cipriancaba

Yeah this would be a nice addition to be able to create news sitemaps

JamesSingleton avatar Aug 09 '22 01:08 JamesSingleton

Hey, any updates on this PR progress? Is there any problem with merging it?

liAmirali avatar Sep 10 '22 08:09 liAmirali

@iamvishnusankar any updates?

rokoroku avatar Oct 22 '22 03:10 rokoroku

We're using GoogleNews sitemaps and using next-sitemap, it would be real handy if this PR could get merged. What's the holdup @iamvishnusankar ?

StewartJ-SSG avatar Nov 07 '22 21:11 StewartJ-SSG

@iamvishnusankar @georgebutter Is anything missing for a merge?

z0lo13 avatar Nov 17 '22 17:11 z0lo13

@z0lo13 , no, but only @iamvishnusankar can merge it.

georgebutter avatar Nov 17 '22 21:11 georgebutter

Closing this PR due to inactivity.

github-actions[bot] avatar Mar 07 '23 04:03 github-actions[bot]

@zuffik Thanks for this PR. Can you please fix the test errors?

Error logs: https://github.com/iamvishnusankar/next-sitemap/actions/runs/4352877388/jobs/7606207567#step:6:41

iamvishnusankar avatar Mar 07 '23 12:03 iamvishnusankar

@iamvishnusankar I fixed it but it's waiting for your approval.

zuffik avatar Mar 07 '23 17:03 zuffik

@zuffik Run yarn format on project root to resolve the formatting errors

iamvishnusankar avatar Mar 07 '23 18:03 iamvishnusankar

@iamvishnusankar done

zuffik avatar Mar 07 '23 18:03 zuffik

@iamvishnusankar Thank you! 😍

zuffik avatar Mar 07 '23 19:03 zuffik