oracledb_exporter icon indicating copy to clipboard operation
oracledb_exporter copied to clipboard

Added support for yaml-formatted configs

Open marinafrank opened this issue 1 year ago • 0 comments

Description

  • Added yaml parser for more readable configs. toml is also still supported.
  • Enchanced log messages: use key-value syntax, added warning message when fallback to hard-coded default metrics
  • Updated readme with some tips from my experience with the oracledb exporter (which I find anyway cool).

Type of change

  • [x] New feature (non-breaking change which adds functionality)
  • [x] This change requires a documentation update

How Has This Been Tested?

make local-build
export DATA_SOURCE_NAME="<connectionstring-to-oracle-19.21.0.0.0>"

# regression test
dist/oracledb_exporter-0.5.2.linux-amd64/oracledb_exporter --default.metrics=./default-metrics.toml --log.level debug
dist/oracledb_exporter-0.5.2.linux-amd64/oracledb_exporter --custom.metrics=./custom-metrics-example/custom-metrics.toml --log.level debug
curl http://localhost:9161

# functional test
dist/oracledb_exporter-0.5.2.linux-amd64/oracledb_exporter --default.metrics=./default-metrics.yaml --log.level debug
dist/oracledb_exporter-0.5.2.linux-amd64/oracledb_exporter --custom.metrics=./custom-metrics-example/custom-metrics.yaml --log.level debug
curl http://localhost:9161

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] Updated version in Makefile respecting semver v2

marinafrank avatar Jan 29 '24 14:01 marinafrank