URL Connection Options Do Not Work

Open seanwhitent opened this issue 2 years ago • 1 comments

[ X] bug report

What is the current behavior?

Following the example in the README, I have tried to add connect_timeout like so export DATA_SOURCE_NAME=oracle://user:password@myhost:1521/service?connect_timeout=30

It returns this error caller=collector.go:262 level=error Errorpingingoracle:="unknown URL option: connection_timeout"

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Add ?connect_timeout to the end of the export DATA_SOURCE_NAME value and try to run the exporter.

What is the expected behavior?

The connection from the exporter to the database is successful and metrics are scraped.

Please tell us about your environment:

ts=2023-07-14T16:39:06.932Z caller=main.go:70 level=info msg="Starting oracledb_exporter" version="(version=, branch=, revision=unknown)"
ts=2023-07-14T16:39:06.932Z caller=main.go:71 level=info msg="Build context" build="(go=go1.18.1, platform=windows/amd64, user=, date=, tags=unknown)"

Version: 0.5.1

Jul 14 '23 16:07 seanwhitent

However, it seems to work okay if I omit the underscore, so maybe it's just a documentation issue in the README export DATA_SOURCE_NAME=oracle://user:password@myhost:1521/service?connect timeout=30

Jul 14 '23 16:07 seanwhitent