oracledb_exporter icon indicating copy to clipboard operation
oracledb_exporter copied to clipboard

Feature Request: Add application version information

Open chrisfw opened this issue 2 years ago • 3 comments

Please consider adding application version information into the application metrics that are output along with the default golang based metrics. It would be great to have a version command line argument as well. Adding this feature will allow always up to date tracking of prometheus monitoring related exporter application versions.

Thanks, Chris Whelan

chrisfw avatar Jan 14 '23 15:01 chrisfw

Hi, It's a good idea. PR are welcome.

Yannig avatar Feb 07 '23 16:02 Yannig

Thanks Seth,

I haven't spent much time in golang, but I will give it a shot.

Regards, Chris

On Tue, Feb 7, 2023 at 11:59 AM Yannig @.***> wrote:

Hi, It's a good idea. PR are welcome.

— Reply to this email directly, view it on GitHub https://github.com/iamseth/oracledb_exporter/issues/268#issuecomment-1421106782, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOZ7PIC2W7M3GR4MNVW3B3WWJ5PPANCNFSM6AAAAAAT3K2BTU . You are receiving this because you authored the thread.Message ID: @.***>

chrisfw avatar Feb 07 '23 18:02 chrisfw

Actually, thinking about it it seems like there should be some integration with the build or CI/CD that creates a version file that gets read by the app?

On Tue, Feb 7, 2023 at 1:06 PM Chris Whelan @.***> wrote:

Thanks Seth,

I haven't spent much time in golang, but I will give it a shot.

Regards, Chris

On Tue, Feb 7, 2023 at 11:59 AM Yannig @.***> wrote:

Hi, It's a good idea. PR are welcome.

— Reply to this email directly, view it on GitHub https://github.com/iamseth/oracledb_exporter/issues/268#issuecomment-1421106782, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOZ7PIC2W7M3GR4MNVW3B3WWJ5PPANCNFSM6AAAAAAT3K2BTU . You are receiving this because you authored the thread.Message ID: @.***>

chrisfw avatar Feb 07 '23 18:02 chrisfw