oracledb_exporter icon indicating copy to clipboard operation
oracledb_exporter copied to clipboard

Published 20 hours ago • verified publisher icon iamseth

BUG: Structured logging in Golang

Open vutkin opened this issue 2 years ago • 4 comments

Hi @Yannig, you did a PR where logger was changed: https://github.com/iamseth/oracledb_exporter/pull/243/files Old logs looks like:

image

New implementation in latest build:

image

Please note that all logs lack of whitespaces Screenshot 2022-12-23 at 15 51 50

I suggest to use json formatted log in PRODUCTION profile and switch to most popular top go loggers. I like https://github.com/sirupsen/logrus.

TIA, Regards, Viktor.

vutkin avatar Dec 23 '22 12:12 vutkin

Hi @vutkin

Do you think we can close this issue?

Regards

Yannig avatar Feb 07 '23 17:02 Yannig

Now latest release looks good, if don't need structured logs in json, so make sense to close it.

vutkin avatar Feb 07 '23 17:02 vutkin

In fact, it can make sense to have a JSON output.

Yannig avatar Feb 07 '23 20:02 Yannig

I let this issue open for the moment and I will try to improve logger if I have time.

Yannig avatar Feb 07 '23 20:02 Yannig