adonisjs-hackathon-starter icon indicating copy to clipboard operation
adonisjs-hackathon-starter copied to clipboard

Question: Any plans to use Adonis-Persona?

Open Maxximus007 opened this issue 7 years ago • 8 comments

The sign-up/login you've supplied works fine, so perhaps no real need to change it, but was wondering if you consider adding the new Adonis-Persona into the starter?

Maxximus007 avatar Jun 29 '18 15:06 Maxximus007

I will look into it..can you provide more information?

iamraphson avatar Jun 29 '18 15:06 iamraphson

Sure! https://github.com/adonisjs/adonis-persona

Maxximus007 avatar Jun 29 '18 16:06 Maxximus007

It does have one advantage, the accountStates.

Maxximus007 avatar Jun 29 '18 16:06 Maxximus007

This would be a great addition. :+1:

niallobrien avatar Nov 22 '18 16:11 niallobrien

@niallobrien @Maxximus007 so we should replace the present login flow with Adonis-Persona?

iamraphson avatar Nov 22 '18 18:11 iamraphson

It is not a drop-in replacement, so it will require some effort to change to Adonis-Persona. But I believe it could give the starter pack a valuable upgrade since it will use the package offered by Adonis itself.

Maxximus007 avatar Nov 26 '18 10:11 Maxximus007

I agree, I think the more Adonis specific packages used, the better.

niallobrien avatar Feb 05 '19 13:02 niallobrien

Any progress on this?

niallobrien avatar Jun 26 '19 15:06 niallobrien