dayjs
dayjs copied to clipboard
iamkun
Fix issue1318 - parsing ISO 8601 string with offset
ISO 8601 date string can have an offset; moment parses this correctly.
Pull request fixes this Issue; tests added / updated.
Codecov Report
Merging #1940 (4471029) into dev (9ef1714) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## dev #1940 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 175 183 +8
Lines 1697 2107 +410
Branches 387 558 +171
==========================================
+ Hits 1697 2107 +410
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/locale/bo.js | 100.00% <ø> (ø) |
|
| src/locale/br.js | 100.00% <ø> (ø) |
|
| src/locale/de.js | 100.00% <ø> (ø) |
|
| src/locale/es-do.js | 100.00% <ø> (ø) |
|
| src/locale/es-pr.js | 100.00% <ø> (ø) |
|
| src/locale/es-us.js | 100.00% <ø> (ø) |
|
| src/locale/es.js | 100.00% <ø> (ø) |
|
| src/locale/fi.js | 100.00% <ø> (ø) |
|
| src/locale/it-ch.js | 100.00% <ø> (ø) |
|
| src/locale/lt.js | 100.00% <ø> (ø) |
|
| ... and 98 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @BePo65 , are you gonna merge it soon or do you still have issues? Thanks a lot.
@BePo65 does your implementation also support parsing date-strings with "2-digit" offsets, like 2018-04-04T16:00:00.000+05 or 2018-04-04T16:00:00-05?
Looking at the edited REGEX_PARSE regular expression it seems so, but I didn't find a test to prove it
@iamkun please, can you merge this change and publish a new package's version?
@StefanoMagrassi thanks for the hint - indeed I missed that point (and fixed it now).
Why has this been sitting here open for almost a year (or at least the last 6 months)? If there is an issue with this PR then please kindly comment on it so it can be resolved or if it's been fixed elsewhere, then comment and close. We are in need of a fix please...
