dayjs icon indicating copy to clipboard operation
dayjs copied to clipboard

Ignore extra object keys in duration input

Open xvaara opened this issue 4 years ago • 2 comments

Inputing a graphql (Postgraphile) interval object results in errors if asked for asMinutes() since the object contains all the keys that are inputed. This only allows keys that are in unitToMS.

Moment discards the extra keys.

xvaara avatar Jun 03 '21 15:06 xvaara

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b5a1391) to head (5c5f103). Report is 190 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1519   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines         1996      1996           
  Branches       507       508    +1     
=========================================
  Hits          1996      1996           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 03 '21 15:06 codecov[bot]

@iamkun any change getting this in a release?

xvaara avatar Oct 21 '21 14:10 xvaara