asus-numpad icon indicating copy to clipboard operation
asus-numpad copied to clipboard

Upstream as kernel driver

Open flukejones opened this issue 1 year ago • 2 comments

Hi! This is the sort of functionality that would be best added to the kernel upstream in https://github.com/torvalds/linux/blob/master/drivers/platform/x86/asus-nb-wmi.c (and asus-wmi.c). The ideal thing would be to have the entire thing in kernel, including the touchpoints config, but right now I'm not 100% sure of the best way to manage that part. Maybe sparking up a conversation on the mailing list or emailing Corentin or Hans de Goede. Hans is a great guy and did all the code review for me.

Even if it was just detect and init the device, plus expose a sysfs point for toggling on/off I think it would dramatically help you with this project, maybe even enough that you could reduce this to a crate we can add to asusctl.

I unfortunately don't have one of these types of laptops so I won't be able to help much (I wrote https://gitlab.com/asus-linux/asusctl and upstreamed most of the ROG stuff like keyboard support, platform-profile support, fan-curves, and other stuff), but I'll try if I can.

If you would like to write a blog post about your project, you can add it to our website at https://asus-linux.org/ through https://gitlab.com/asus-linux/website

P.S: You might be interested in the virt keyboard I did before pulling out functionality in to kernel patches - https://github.com/flukejones/rog-core/blob/master/rog-core/src/virt_device.rs

flukejones avatar Jul 08 '22 04:07 flukejones